Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Expose IndexFile in Split. #3226

Merged
merged 22 commits into from
Apr 26, 2024
Merged

[core] Expose IndexFile in Split. #3226

merged 22 commits into from
Apr 26, 2024

Conversation

leaves12138
Copy link
Contributor

  • REASON
    After bloom-filter added to paimon, we should find extra files in RawFile.

@JingsongLi
Copy link
Contributor

JingsongLi commented Apr 19, 2024 •
edited
Loading

Maybe just like Deletion Files, expose a method in Split class?
Optional<List<IndexFile>> indexFiles() something like this?

@JingsongLi
Copy link
Contributor

Let RawFile be a real raw file, nothing else.

@leaves12138 leaves12138 requested a review from JingsongLi April 19, 2024 10:23
@leaves12138 leaves12138 reopened this Apr 22, 2024
@leaves12138 leaves12138 changed the title [core] Add extra files to RawFile. [core] Expose IndexFile in Split. Apr 22, 2024
@leaves12138 leaves12138 requested a review from JingsongLi April 24, 2024 08:30
JingsongLi
JingsongLi approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 01f0764 into apache:master Apr 26, 2024
9 checks passed
@Zouxxyy Zouxxyy mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leaves12138 @JingsongLi