[flink] support to infer parallelism for system table #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Apr 12, 2024
| @@ -139,4 +158,34 @@ public void applyDynamicFiltering(List<String> candidateFilterFields) { | |||
| public boolean isStreaming() { | |||
| return isStreamingMode; | |||
| } | |||
|
|
|||
| private DataStreamSource<RowData> configSourceParallelism( | |||
There was a problem hiding this comment.
Why not reuse DataTableSource.configureSource?
There was a problem hiding this comment.
I just think for system table, the streaming mode's parallelism should not be the options.get(CoreOptions.BUCKET). It's better reuse this method, will refactor it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, the
scan.parallelismandscan.infer-parallelismis not work for system table. We should implement this because we havero/audit_logtableLinked issue: close #xxx
Tests
API and Format
Documentation