[core] Fix duplicate primary keys in query results #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhourui999
changed the title
zhourui999
changed the title
zhourui999
changed the title
zhourui999
changed the title
|
Thanks for pointing it out! |
Zouxxyy
approved these changes
Apr 7, 2024
| .withSnapshot(snapshotId) | ||
| .withPartition(partition) | ||
| .withBucket(bucket) | ||
| .isStreaming(isStreaming); | ||
| List<DataFileMeta> dataFiles = splitGroup.files; | ||
| builder.withDataFiles(dataFiles); | ||
| if (splitGroup.rawConvertible) { |
There was a problem hiding this comment.
It can also be modified this way.
I think the current implementation is okay too, what do you think? @JingsongLi
builder.rawFiles(
splitGroup.rawConvertible
? convertToRawFiles(partition, bucket, dataFiles)
: Collections.emptyList());
There was a problem hiding this comment.
Okay,I think your suggestion is better. I'll make some changes
|
+1 |
zhourui999
force-pushed
the
bug_fix_same_primary_key
branch
from
275da6e to
249dacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #3157
Because the same builder is used in the for loop of generateSplits in SnapshotReaderImpl, if rawConvertible is true the last time, it will affect the value of the next Datasplit rawFiles. The ultimate result is the need for MergeRedier's Datasplit, as rawFiles were mistakenly set and NoMergeReader was created, resulting in duplicate data during reading
Tests
API and Format
Documentation