Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix failed tests in FileStoreCommitTest #3145

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[core] Fix failed tests in FileStoreCommitTest #3145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf7d1b
[core] Fix failed tests in FileStoreCommitTest
Apr 2, 2024
b8547d6
[fix] Fix checkstyle
Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
*
* <p>NOTE: If you want to modify this class, any exception during commit MUST NOT BE IGNORED. They
* must be thrown to restart the job. It is recommended to run FileStoreCommitTest thousands of
* times to make sure that your changes is correct.
* times to make sure that your changes are correct.
*/
public class FileStoreCommitImpl implements FileStoreCommit {

Expand Down
5 changes: 0 additions & 5 deletions paimon-core/src/test/java/org/apache/paimon/operation/FileStoreCommitTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,11 +559,6 @@ public void testCommitOldSnapshotAgain() throws Exception {
.isInstanceOf(RuntimeException.class)
.hasMessageContaining("Give up committing.");
}

// commit without check, should pass
for (int i = 0; i < 3; i++) {
store.newCommit().commit(committables.get(0), Collections.emptyMap());
}
}

@Test
Expand Down
Loading