[Format]ORC Support ZStandard compression using zstd-jni #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zyl891229 , thanks for the contribution! Is apache/orc#988 based on ORC 1.9? |
|
Hi @JingsongLi |
zhu3pang
pushed a commit
to zhu3pang/incubator-paimon
that referenced
this pull request
Mar 29, 2024
Zouxxyy
reviewed
Apr 9, 2024
| import java.util.Properties; | ||
|
|
||
| /** Define the configuration properties that Orc understands. */ | ||
| public enum OrcConf { |
There was a problem hiding this comment.
@zyl891229 @JingsongLi I encountered the class conflict in my local test, there may be problems with class with the same name.
Caused by: java.lang.NoSuchFieldError: COMPRESSION_ZSTD_LEVEL
at org.apache.paimon.format.OrcOptions.<clinit>(OrcOptions.java:42)
at org.apache.paimon.format.orc.OrcWriterFactory.create(OrcWriterFactory.java:132)
at org.apache.paimon.io.SingleFileWriter.<init>(SingleFileWriter.java:68)
at org.apache.paimon.io.StatsCollectingSingleFileWriter.<init>(StatsCollectingSingleFileWriter.java:57)
at org.apache.paimon.io.RowDataFileWriter.<init>(RowDataFileWriter.java:57)
at org.apache.paimon.io.RowDataRollingFileWriter.lambda$new$0(RowDataRollingFileWriter.java:53)
at org.apache.paimon.io.RollingFileWriter.openCurrentWriter(RollingFileWriter.java:99)
at org.apache.paimon.io.RollingFileWriter.write(RollingFileWriter.java:78)
at org.apache.paimon.append.AppendOnlyWriter$DirectSinkWriter.write(AppendOnlyWriter.java:347)
at org.apache.paimon.append.AppendOnlyWriter.write(AppendOnlyWriter.java:144)
at org.apache.paimon.append.AppendOnlyWriter.write(AppendOnlyWriter.java:60)
at org.apache.paimon.operation.AbstractFileStoreWrite.write(AbstractFileStoreWrite.java:126)
at org.apache.paimon.table.sink.TableWriteImpl.writeAndReturn(TableWriteImpl.java:145)
at org.apache.paimon.table.sink.TableWriteImpl.write(TableWriteImpl.java:126)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support ZStandard compression using zstd-jni.
ORC Original PR: apache/orc#988
Support the use of zstd-jni library as the implementation of ORC zstd,
with better performance than aircompressor.
But ORC support it from 2.0.0 ,but it also drop java 8 at the same version.
Tests
org.apache.paimon.format.orc.writer.OrcZstdTest
API and Format
Documentation