Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] ignore expiration check interval of partition in batch mode. #2970

Closed
wants to merge 1 commit into from
Closed

[flink] ignore expiration check interval of partition in batch mode. #2970

wants to merge 1 commit into from

Conversation

zhoulii
Copy link
Member

@zhoulii zhoulii commented Mar 7, 2024

Purpose

Linked issue: close #2969

If the execution time of a batch job is short, and it's less than the interval for partition expiration checks, the partition expiration operations will not be executed. This PR aims to ignore partition expiration check interval for batch job.

Tests

API and Format

Documentation

@zhoulii
Copy link
Member Author

zhoulii commented Mar 7, 2024

Hi @Aitozi , could you please take a look at this PR? Thanks.

@@ -117,6 +124,10 @@ private List<BinaryRow> readPartitions(LocalDateTime expireDateTime) {
.collect(Collectors.toList());
}

public void ignoreExpireCheckInterval() {
Copy link
Contributor

@JingsongLi JingsongLi Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can add endInput to this class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I didn't fully grasp your point. Are you suggesting that we should change the method name?

@zhoulii zhoulii closed this by deleting the head repository Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] ignore expiration check interval of partition in batch mode.
2 participants