[core] add commit.force-expire option #2968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhoulii
changed the title
|
Hi @Aitozi , could you please take a look at this PR? Thanks. |
JingsongLi
reviewed
Mar 18, 2024
| @@ -378,6 +378,12 @@ public class CoreOptions implements Serializable { | |||
| .defaultValue(MemorySize.ofMebiBytes(128)) | |||
| .withDescription("Target size of a file."); | |||
|
|
|||
| public static final ConfigOption<Boolean> FORCE_EXPIRE = | |||
There was a problem hiding this comment.
Maybe it is better to introduce an option: write.responsible-matters, similar option, I'm not good at naming it, for reference only.
In the option, user can specific what the write does.
There was a problem hiding this comment.
how about commit.force.hooks or commit.force.triggers ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2967
Sort compact only supports write-only mode, during which expiration operations are not performed. When users write data in write-only mode and use sort compact for sorting and merging, expired deletion cannot be executed. This PR add an option to force expiration.