Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Integrate deletion vector to reader and writer #2958

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Mar 7, 2024

Purpose

subTask of #2898, in this PR:

  • add a new conf deletion-vectors.enabled to control whether deletion vector mode is enabled. Limit:

    • pk table
    • file.format = orc or parquet
    • changelog-producer = none or lookup
    • merge-engine != first-row (implement it in the future)
  • integrate deletion vector to reader and writer, when deletion-vectors.enabled is true:

    • for writer: update dv index when lookup, since drop delete is necessary, rewrite is always required in lookup compaction
    • for reader: introduce ApplyDeletionVectorReader for applying DeletionVector to filter record

Tests

API and Format

Documentation

@Zouxxyy Zouxxyy force-pushed the dv/3-apply-deletion-vector-new branch from 18fe682 to 70c4c3f Compare March 8, 2024 07:45
@JingsongLi JingsongLi force-pushed the dv/3-apply-deletion-vector-new branch from 70c4c3f to eb774c5 Compare March 9, 2024 04:52
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit dfb5278 into apache:master Mar 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants