Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] Introduce max_pt for Flink lookup join #2926

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

In many cases, data is stored in the payload by partition, and each partition contains the full amount of data, while the latest data is often stored in the latest partition.

We introduce a max_pt mechanism here to only look up the latest partition.

Tests

API and Format

Documentation

Copy link
Contributor

@Aitozi Aitozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left one minor comments

@@ -75,8 +79,18 @@ public FullCacheLookupTable(Context context) throws IOException {
this.projectedType = projectedType;
}

@Override
public void specificPartition(BinaryRow partition) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This partition predicate can also push to the partial cache scanner.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right! Thanks!

@JingsongLi JingsongLi merged commit df2cf19 into apache:master Mar 1, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants