Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][DV] Support obtain row position when reading orc and parquet #2909

Closed
wants to merge 2 commits into from

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Feb 27, 2024

Purpose

This is the first step of #2898, in this PR:

  • add new config deletion-vectors.enabled which default is false and should only be used with PK table and orc/parquet format currently
  • add system col _ROW_POSITION
  • add rowPosition in KeyValue and set it when deletion-vectors.enabled is true
  • support obtain rowPosition when reading orc and parquet

Tests

API and Format

Documentation

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, having an additional field for KeyValue may have a significant impact, for example, after Merging, this field will be meaningless.

A less invasive approach could be to introduce a new RecordReader.RecordIterator, for example, adding the RecordWithPositionIterator class:

public interface RecordWithPositionIterator<T> extends RecordIterator<T> {
    long currentPosition();
}

@Zouxxyy
Copy link
Contributor Author

Zouxxyy commented Feb 28, 2024

closed by new implement #2916

@Zouxxyy Zouxxyy closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants