[core] Agg 'collect' and 'merge_map' support retract #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
approved these changes
Jan 30, 2024
JingsongLi
reviewed
Jan 31, 2024
| @@ -83,7 +83,8 @@ public ChangelogMode getChangelogMode(ChangelogMode requestedMode) { | |||
| return requestedMode; | |||
| } | |||
|
|
|||
| if (options.get(MERGE_ENGINE) == MergeEngine.AGGREGATE) { | |||
| MergeEngine mergeEngine = options.get(MERGE_ENGINE); | |||
| if (mergeEngine == MergeEngine.AGGREGATE || mergeEngine == MergeEngine.PARTIAL_UPDATE) { | |||
There was a problem hiding this comment.
check if agg func is defined
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The retract isn't correct when:
for example, using merge_map, acc (1, A) + input (1, B) will get (1, B), and if retract (1, A) later, the result (1, B) will be deleted from result map.
Tests
API and Format
Documentation