Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Use binary search to optimize SnapshotManager#earlierThanTimeMills #2805

Merged
merged 2 commits into from
Feb 22, 2024
Merged

[core] Use binary search to optimize SnapshotManager#earlierThanTimeMills #2805

merged 2 commits into from
Feb 22, 2024

Conversation

tsreaper
Copy link
Contributor

Purpose

This PR optimizes SnapshotManager#earlierThanTimeMills with binary search.

Tests

Existing tests should cover this change.

API and Format

No.

Documentation

No.

JingsongLi
JingsongLi reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsreaper , can you add some ut cases?

JingsongLi
JingsongLi approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 55c038f into apache:master Feb 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsreaper @JingsongLi