[cdc] Use CdcSourceRecord as source type instead of raw String #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harveyyue
force-pushed
the
refactor-source-record
branch
from
13ae750 to
72b36be
Compare
|
@yuzelin Could you help to review it? |
|
Thanks for contributing! We are planning to cut release 0.7.0 branch today (Jan. 25). Since this PR is refactor, I will review later. |
harveyyue
force-pushed
the
refactor-source-record
branch
from
72b36be to
f52aaa5
Compare
harveyyue
force-pushed
the
refactor-source-record
branch
2 times, most recently
from
eae2a49 to
0884d62
Compare
harveyyue
force-pushed
the
refactor-source-record
branch
from
0884d62 to
23e2549
Compare
|
I have optimized a version, and next I want to implement records that receive generic structures, but this is very difficult to modify. |
yuzelin
reviewed
Apr 26, 2024
...flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcSourceRecord.java
Outdated
Show resolved
Hide resolved
...k/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/format/RecordParser.java
Show resolved
Hide resolved
...k/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/format/RecordParser.java
Show resolved
Hide resolved
|
Thanks @harveyyue and sorry for my late response. Thanks @zhuangchong for resolving the conflicts and tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor the cdc source record, it will help to implement more data formats.
Tests
API and Format
Documentation