[flink] Delete in flink should produce changelog no matter what #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
force-pushed
the
delete_improve
branch
from
9104fe1 to
8c18680
Compare
JingsongLi
reviewed
Jan 9, 2024
leaves12138
force-pushed
the
delete_improve
branch
from
474ed4e to
61e4e23
Compare
Done |
leaves12138
force-pushed
the
delete_improve
branch
from
028b830 to
610db41
Compare
JingsongLi
reviewed
Apr 26, 2024
...mmon/src/main/java/org/apache/paimon/flink/sink/SupportsRowLevelOperationFlinkTableSink.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Apr 26, 2024
JingsongLi
reviewed
Apr 26, 2024
...mmon/src/main/java/org/apache/paimon/flink/sink/SupportsRowLevelOperationFlinkTableSink.java
Outdated
Show resolved
Hide resolved
|
+1 |
sunxiaojian
pushed a commit
to sunxiaojian/paimon
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Delete one partition in flink will not produce changelog. But anyway, it should. The pr has done two things:
1、Before delete push down, check the row count, if row number is bigger than 100_0000, we generate a job to finish delete. (Do not apply push down)\
2、Delete the partition by per-record set (set the record kind to RowKing.DELETE, then write it back) in Delete push down action.
fix #1508
Tests
API and Format
Documentation