Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][hotfix] fix typo #2518

Closed
wants to merge 4 commits into from
Closed

[WIP][hotfix] fix typo #2518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a79468
[hotfix] fix typo
Dec 17, 2023
9633e5e
[hotfix] fix typo
Dec 17, 2023
1d34030
[hotfix] fix typo
Dec 17, 2023
e8f436b
[hotfix] fix typo
Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/SyncDatabaseActionBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ protected void validateCaseSensitivity() {
}

@Override
protected FlatMapFunction<String, RichCdcMultiplexRecord> recordParse() {
protected FlatMapFunction<String, RichCdcMultiplexRecord> recordParser() {
return syncJobHandler.provideRecordParser(
caseSensitive, Collections.emptyList(), typeMapping, metadataConverters);
}
Expand Down
2 changes: 1 addition & 1 deletion ...aimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/SyncTableActionBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ protected void beforeBuildingSourceSink() throws Exception {
}

@Override
protected FlatMapFunction<String, RichCdcMultiplexRecord> recordParse() {
protected FlatMapFunction<String, RichCdcMultiplexRecord> recordParser() {
return syncJobHandler.provideRecordParser(
caseSensitive, computedColumns, typeMapping, metadataConverters);
}
Expand Down
4 changes: 2 additions & 2 deletions ...flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/SynchronizationActionBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public void build() throws Exception {
beforeBuildingSourceSink();

DataStream<RichCdcMultiplexRecord> input =
buildDataStreamSource(buildSource()).flatMap(recordParse()).name("Parse");
buildDataStreamSource(buildSource()).flatMap(recordParser()).name("Parse");

EventParser.Factory<RichCdcMultiplexRecord> parserFactory = buildEventParserFactory();

Expand Down Expand Up @@ -135,7 +135,7 @@ private DataStreamSource<String> buildDataStreamSource(Object source) {
throw new UnsupportedOperationException("Unrecognized source type");
}

protected abstract FlatMapFunction<String, RichCdcMultiplexRecord> recordParse();
protected abstract FlatMapFunction<String, RichCdcMultiplexRecord> recordParser();

protected abstract EventParser.Factory<RichCdcMultiplexRecord> buildEventParserFactory();

Expand Down
2 changes: 1 addition & 1 deletion ...cdc/src/main/java/org/apache/paimon/flink/sink/cdc/CdcMultiplexRecordChannelComputer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private ChannelComputer<CdcRecord> computeChannelComputer(CdcMultiplexRecord rec
FileStoreTable table;
try {
table = (FileStoreTable) catalog.getTable(id);
table.copy(dynamicOptions);
table = table.copy(dynamicOptions);
} catch (Catalog.TableNotExistException e) {
LOG.error("Failed to get table " + id.getFullName());
return null;
Expand Down
2 changes: 1 addition & 1 deletion ...-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/CdcRecordStoreMultiWriteOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ private FileStoreTable getTable(Identifier tableId) throws InterruptedException
while (true) {
try {
table = (FileStoreTable) catalog.getTable(tableId);
table.copy(dynamicOptions);
table = table.copy(dynamicOptions);
tables.put(tableId, table);
break;
} catch (Catalog.TableNotExistException e) {
Expand Down
11 changes: 6 additions & 5 deletions ...k-cdc/src/main/java/org/apache/paimon/flink/sink/cdc/FlinkCdcSyncDatabaseSinkBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,18 +141,19 @@ private void buildCombinedCdcSink() {
.name("Side Output")
.setParallelism(input.getParallelism());

// for newly-added tables, create a multiplexing operator that handles all their records
// and writes to multiple tables
DataStream<CdcMultiplexRecord> newlyAddedTableStream =
SingleOutputStreamOperatorUtils.getSideOutput(
parsed, CdcDynamicTableParsingProcessFunction.DYNAMIC_OUTPUT_TAG);
// handles schema change for newly added tables
SingleOutputStreamOperatorUtils.getSideOutput(
parsed,
CdcDynamicTableParsingProcessFunction.DYNAMIC_SCHEMA_CHANGE_OUTPUT_TAG)
.process(new MultiTableUpdatedDataFieldsProcessFunction(catalogLoader))
.name("Schema Evolution");

// for newly-added tables, create a multiplexing operator that handles all their records
// and writes to multiple tables
DataStream<CdcMultiplexRecord> newlyAddedTableStream =
SingleOutputStreamOperatorUtils.getSideOutput(
parsed, CdcDynamicTableParsingProcessFunction.DYNAMIC_OUTPUT_TAG);

DataStream<CdcMultiplexRecord> partitioned =
partition(
newlyAddedTableStream,
Expand Down
Loading