Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spark] Merge Into: When Not Matched By Source #2517

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[Spark] Merge Into: When Not Matched By Source #2517

merged 1 commit into from
Dec 22, 2023

Conversation

YannByron
Copy link
Contributor

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

JingsongLi
JingsongLi reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR, can we create an abstraction for MergeIntoTableTest. Just like TestTrinoITCase, every spark module has a class to extend this, test merge into feature for every Spark versions.

@JingsongLi
Copy link
Contributor

https://github.com/apache/incubator-paimon-trino/blob/main/paimon-trino-common/src/test/java/org/apache/paimon/trino/TestTrinoITCase.java
And
https://github.com/apache/incubator-paimon-trino/blob/main/paimon-trino-388/src/test/java/org/apache/paimon/trino/TestTrino388ITCase.java

JingsongLi
JingsongLi approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 554ae64 into apache:master Dec 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannByron @JingsongLi