[flink] Do not create default database if ddl in it is disable #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FangYongs
force-pushed
the
2499_disable_create_default_database
branch
from
771c414 to
caca7ec
Compare
FangYongs
changed the title
JingsongLi
reviewed
Dec 13, 2023
| @@ -148,7 +148,7 @@ public FlinkCatalog( | |||
| this.logStoreAutoRegister = options.get(LOG_SYSTEM_AUTO_REGISTER); | |||
| this.logStoreAutoRegisterTimeout = options.get(REGISTER_TIMEOUT); | |||
| this.disableCreateTableInDefaultDatabase = options.get(DISABLE_CREATE_TABLE_IN_DEFAULT_DB); | |||
| if (!catalog.databaseExists(defaultDatabase)) { | |||
| if (!disableCreateTableInDefaultDatabase && !catalog.databaseExists(defaultDatabase)) { | |||
There was a problem hiding this comment.
Maybe here we can just create default database for FileSystemCatalog?
FangYongs
force-pushed
the
2499_disable_create_default_database
branch
from
caca7ec to
63d6508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2499
If
disable-create-table-in-default-dbis true, flink catalog should not create default databaseTests
FlinkCatalogTestAPI and Format
no
Documentation
no