-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema] Support database path for specified database in catalog #2494
[schema] Support database path for specified database in catalog #2494
Conversation
e4a2619
to
50ff181
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @FangYongs
Does this come from real business needs? In my previous understanding, this situation is usually solved by the FileSystem of HDFS. (Or Flink FileSystem)
@JingsongLi Yes. Currently in our production environment, we always support one catalog for hive, hudi, iceberg or paimon, so they can easily read/write tables use |
Can Hadoop FileSystem solve this? #2504 |
@JingsongLi It seems not, What do you think? |
Can you list what FileSystems need to be supported? |
For example, Hadoop FileSystem supports viewfs, there can be multiple underly filesystems. |
@JingsongLi Local file system, hdfs or s3 which have beed supported in paimon |
We may configure different hdfs cluster for different databases in the paimon catalog, do you mean we can get different filesystem from one |
Yes |
From Paimon Level, you can do this too. Just like current |
@JingsongLi Get it. Then I think we can add minor updates in paimon to support different database paths for catalog, I will update this PR |
50ff181
to
ee6f079
Compare
@JingsongLi What do you think of this PR now? We can implement customized catalog and get warehouse path with specified database name |
ee6f079
to
2316916
Compare
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java
Show resolved
Hide resolved
eaa20e1
to
b49f672
Compare
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java
Outdated
Show resolved
Hide resolved
b49f672
to
ce99efd
Compare
@JingsongLi Can you help to review this PR again? THX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose
Linked issue: close #2493
Currently there will be
FileIO
when a catalog is created. We would like to support path fordatabase
and paimon need to get fileio for each database when it is created, dropped and tables are created, dropped for it. This PR aims to introduceDatabaseFileIOProvider
in catalog to get fileio for given database name.Tests
Exist tests can cover this feature.
API and Format
no
Documentation
no