Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] time travel add datetime format #2491

Merged
merged 22 commits into from
Jun 17, 2024

Conversation

seawenc
Copy link
Contributor

@seawenc seawenc commented Dec 12, 2023

Purpose

Linked issue: #2475

Tests

unit test is paas

integration testing:

flink test

image

hive test

image

@seawenc seawenc changed the title [Feature] time travel add datetime format [core] time travel add datetime format Dec 12, 2023
-- read the snapshot from specified datetime
-- Supported formats include:yyyy,yyyy-MM,yyyy-MM-dd, yyyy-MM-dd HH, yyyy-MM-dd HH:mm, yyyy-MM-dd HH:mm:ss, yyyy-MM-dd HH:mm:ss.SSS
-- default local time zone,If you need to specify a time zone, please end with '/UTC{offset}',for example: 2023-12-11 12:12/UTC+8
SELECT * FROM t /*+ OPTIONS('scan.datetime' = '2023-12-09 23:09') */;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just scan.timestamp?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been modified to scan.timestamp ,please recheck!

image

@seawenc seawenc requested a review from JingsongLi December 23, 2023 01:59
@seawenc
Copy link
Contributor Author

seawenc commented Jan 4, 2024

@JingsongLi Please recheck!

* @param timestampString
* @return
*/
public static Timestamp autoFormatToTimestamp(String timestampString) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use parseTimestampData? It is very confused to introduce another parser here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingsongLi Fixed,Please recheck!

@seawenc seawenc requested a review from JingsongLi January 15, 2024 08:20
@JingsongLi
Copy link
Contributor

+1 thanks @seawenc for the contribution!

@JingsongLi JingsongLi merged commit 5af852e into apache:master Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants