[core] Add validation to forbid setting stream-read-overwrite with 'full-compaction' or 'lookup' changelog producer #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ull-compaction' or 'lookup' changelog producer
JingsongLi
reviewed
Oct 27, 2023
| || changelogProducer == ChangelogProducer.LOOKUP)) { | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Cannot set %s to true when changelog producer is %s or %s.", |
There was a problem hiding this comment.
Add why, and add a test in CatalogTableITCase.
schnappi17
pushed a commit
to schnappi17/flink-table-store
that referenced
this pull request
Nov 8, 2023
…ull-compaction' or 'lookup' changelog producer (apache#2180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is because
full-compactionandlookupchangelog producers will output the changes in later compact snapshot. If we read the changes of the overwrite snapshot, the output is duplicated.Tests
API and Format
Documentation