[flink][cdc] Add operator and transformation name for cdc pipeline #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangchong
reviewed
Oct 17, 2023
Comment on lines
103
to
106
| LOG.error( | ||
| "Cannot create newly added Paimon table " | ||
| + identifier.getFullName(), | ||
| e); |
There was a problem hiding this comment.
LOG.error("Cannot create newly added Paimon table: {}.", identifier.getFullName(), e); ?
There was a problem hiding this comment.
Seems this method will consider the exception as the second string argument?
@param format the format string
@param arg1 the first argument
@param arg2 the second argument
public void error(String format, Object arg1, Object arg2);
There was a problem hiding this comment.
slf4j will internally judge the last parameter.
|
+1 |
pongandnoon
pushed a commit
to tongcheng-elong/incubator-paimon
that referenced
this pull request
Nov 1, 2023
…pache#2135) (cherry picked from commit 8764854)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A tiny refactor for better experience on Flink UI.
Tests
API and Format
Documentation