Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink] Correct the partitioning for multi-table CDC between write to commit #2133

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Oct 16, 2023

Purpose

Currently, the parallelism is set to 1 but actually the cdc records can be shuffled by table name. This PR fix it.

Tests

API and Format

Documentation

@yuzelin yuzelin changed the title [flink] Correct the sink parallelism setting for multi-table CDC committer [flink] Correct the partitioning for multi-table CDC between write to commit Oct 16, 2023
commitUser,
createCommitterFactory(),
createCommittableStateManager()))
.setParallelism(input.getParallelism());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test for this.

@yuzelin yuzelin requested a review from JingsongLi October 17, 2023 08:07
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 5d4dbbe into apache:master Oct 17, 2023
8 checks passed
@yuzelin yuzelin deleted the improve branch October 17, 2023 08:14
pongandnoon pushed a commit to tongcheng-elong/incubator-paimon that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants