[core] Trim key field in reading, map it to value field #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
added 2 commits
December 6, 2024 14:24
leaves12138
changed the title
|
If these fields are not used when reading, can we do not store them when writing |
Correct, I am working on trimming them from writing. |
tsreaper
reviewed
Dec 9, 2024
paimon-core/src/main/java/org/apache/paimon/utils/BulkFormatMapping.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/utils/BulkFormatMapping.java
Outdated
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/table/SpecialFields.java
Outdated
Show resolved
Hide resolved
tsreaper
reviewed
Dec 9, 2024
paimon-core/src/main/java/org/apache/paimon/utils/BulkFormatMapping.java
Outdated
Show resolved
Hide resolved
paimon-core/src/test/java/org/apache/paimon/utils/BulkFormatMappingTest.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Dec 9, 2024
paimon-core/src/main/java/org/apache/paimon/io/KeyValueFileReaderFactory.java
Outdated
Show resolved
Hide resolved
…ppingTest.java Co-authored-by: tsreaper <[email protected]>
…pping.java Co-authored-by: tsreaper <[email protected]>
2 tasks
tsreaper
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The key-value storage (in primary-key table) are redundant.
Read key-value from storage may appear to fetch more fields than we need.
For example, the format of a row is: _KEY_a, _KEY_b, _FIELD_SEQUENCE, _ROW_KIND, a, b, c, d, e, f, g
The column "a" and "b" have double read. A optimization is:
While reading, we find the
a,bfrom value and fill them to key.Tests
API and Format
Documentation