Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Introduce compactionCompletedCount/compactionQueuedCount metrics. #4391

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

zhuyaogai
Copy link
Contributor

@zhuyaogai zhuyaogai commented Oct 28, 2024

Purpose

Linked issue: #4063 and add some metrics about compaction for paimon (includes compactionsCompletedCount/compactionsQueuedCount).

Tests

Existing tests

API and Format

No

Documentation

No

@zhuyaogai
Copy link
Contributor Author

@JingsongLi hi, master, could you help me review this? Thanks!

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update documentation and explain the meaning for new metrics?

@zhuyaogai zhuyaogai changed the title [core] Introduce compactionsCompletedCount/compactionsFailedCount/compactionsQueuedCount metrics. [core] Introduce compactionCompletedCount/compactionQueuedCount metrics. Oct 29, 2024
@zhuyaogai
Copy link
Contributor Author

Can you update documentation and explain the meaning for new metrics?

done.

@zhuyaogai zhuyaogai requested a review from Aitozi October 29, 2024 08:44
Copy link
Contributor

@Aitozi Aitozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit e7010ee into apache:master Oct 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants