Skip to content

Commit

Permalink
[orc] keep useSelected and allowSARGToFilter close default, or deleti…
Browse files Browse the repository at this point in the history
…on vectors would not work
  • Loading branch information
ranxianglei.rxl committed Sep 27, 2024
1 parent 2226fb9 commit ee915c8
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,10 @@ private static RecordReader createRecordReader(
.tolerateMissingSchema(
OrcConf.TOLERATE_MISSING_SCHEMA.getBoolean(conf));
if (!conjunctPredicates.isEmpty()) {
options.useSelected(true);
options.allowSARGToFilter(true);
// TODO fix it , if open this option,future deletion vectors would not work,
// cased by getRowNumber would be changed .
options.useSelected(OrcConf.READER_USE_SELECTED.getBoolean(conf));
options.allowSARGToFilter(OrcConf.ALLOW_SARG_TO_FILTER.getBoolean(conf));
}
// configure filters
if (!conjunctPredicates.isEmpty()) {
Expand Down

0 comments on commit ee915c8

Please sign in to comment.