[core] resolve withBuckets commit

apache · Nov 15, 2024 · e401844 · e401844
1 parent a1cc9f4
commit e401844
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 4 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreScan.java b/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreScan.java
@@ -440,9 +440,8 @@ private Filter<InternalRow> createCacheRowFilter() {
     }
 
     /**
-     * Read the corresponding entries based on the current required partition and bucket.
-     *
-     * <p>Implemented to {@link InternalRow} is for performance (No deserialization).
+     * Read the corresponding entries based on the current required bucket, but push down into file
+     * format .
      */
     private static List<Predicate> createPushDownFilter(Collection<Integer> buckets) {
         if (buckets == null || buckets.isEmpty()) {

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/FallbackReadFileStoreTable.java b/paimon-core/src/main/java/org/apache/paimon/table/FallbackReadFileStoreTable.java
@@ -34,6 +34,7 @@
 import org.apache.paimon.table.source.DataSplit;
 import org.apache.paimon.table.source.DataTableScan;
 import org.apache.paimon.table.source.InnerTableRead;
+import org.apache.paimon.table.source.InnerTableScan;
 import org.apache.paimon.table.source.Split;
 import org.apache.paimon.table.source.TableRead;
 import org.apache.paimon.table.source.TableScan;
@@ -44,6 +45,7 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -266,6 +268,13 @@ public Scan withBucketFilter(Filter<Integer> bucketFilter) {
             return this;
         }
 
+        @Override
+        public InnerTableScan withBuckets(Collection<Integer> buckets) {
+            mainScan.withBuckets(buckets);
+            fallbackScan.withBuckets(buckets);
+            return this;
+        }
+
         @Override
         public Scan withLevelFilter(Filter<Integer> levelFilter) {
             mainScan.withLevelFilter(levelFilter);

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/source/InnerTableScan.java b/paimon-core/src/main/java/org/apache/paimon/table/source/InnerTableScan.java
@@ -54,7 +54,8 @@ default InnerTableScan withBucket(Integer bucket) {
     }
 
     default InnerTableScan withBuckets(Collection<Integer> buckets) {
-        throw new RuntimeException("not impl withBuckets for " + this.getClass().getName());
+        // return this is not safe for too many class not impl this method and withBucketFilter
+        return this;
     }
 
     default InnerTableScan withLevelFilter(Filter<Integer> levelFilter) {

diff --git a/paimon-core/src/main/java/org/apache/paimon/table/system/AuditLogTable.java b/paimon-core/src/main/java/org/apache/paimon/table/system/AuditLogTable.java
@@ -441,6 +441,12 @@ public InnerTableScan withBucketFilter(Filter<Integer> bucketFilter) {
             return this;
         }
 
+        @Override
+        public InnerTableScan withBuckets(Collection<Integer> buckets) {
+            batchScan.withBuckets(buckets);
+            return this;
+        }
+
         @Override
         public InnerTableScan withLevelFilter(Filter<Integer> levelFilter) {
             batchScan.withLevelFilter(levelFilter);
@@ -478,6 +484,18 @@ public StreamDataTableScan withFilter(Predicate predicate) {
             return this;
         }
 
+        @Override
+        public InnerTableScan withBucketFilter(Filter<Integer> bucketFilter) {
+            streamScan.withBucketFilter(bucketFilter);
+            return this;
+        }
+
+        @Override
+        public InnerTableScan withBuckets(Collection<Integer> buckets) {
+            streamScan.withBuckets(buckets);
+            return this;
+        }
+
         @Override
         public StartingContext startingContext() {
             return streamScan.startingContext();