fix

apache · Dec 16, 2024 · d71e946 · d71e946
1 parent d687110
commit d71e946
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java b/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java
@@ -310,19 +310,19 @@ public static List<Predicate> devolveDataFilters(
                         return Optional.empty();
                     }
 
-                    List<Object> evolvedLiterals =
+                    List<Object> devolvedLiterals =
                             CastExecutors.safelyCastLiteralsWithNumericEvolution(
                                     predicate, dataField.type());
 
-                    return evolvedLiterals == null
+                    return devolvedLiterals == null
                             ? Optional.empty()
                             : Optional.of(
                                     new LeafPredicate(
                                             predicate.function(),
                                             dataField.type(),
                                             indexOf(dataField, idToDataFields),
                                             dataField.name(),
-                                            evolvedLiterals));
+                                            devolvedLiterals));
                 };
 
         for (Predicate predicate : filters) {

diff --git a/paimon-core/src/main/java/org/apache/paimon/stats/SimpleStatsEvolutions.java b/paimon-core/src/main/java/org/apache/paimon/stats/SimpleStatsEvolutions.java
@@ -82,13 +82,13 @@ public Predicate tryDevolveFilter(long dataSchemaId, Predicate filter) {
         if (tableSchemaId == dataSchemaId) {
             return filter;
         }
-        List<Predicate> evolved =
+        List<Predicate> devolved =
                 Objects.requireNonNull(
                         SchemaEvolutionUtil.devolveDataFilters(
                                 schemaFields.apply(tableSchemaId),
                                 schemaFields.apply(dataSchemaId),
                                 Collections.singletonList(filter)));
-        return evolved.isEmpty() ? null : evolved.get(0);
+        return devolved.isEmpty() ? null : devolved.get(0);
     }
 
     public List<DataField> tableDataFields() {

diff --git a/paimon-core/src/test/java/org/apache/paimon/schema/SchemaEvolutionUtilTest.java b/paimon-core/src/test/java/org/apache/paimon/schema/SchemaEvolutionUtilTest.java
@@ -265,7 +265,7 @@ public void testCreateDataProjection() {
     }
 
     @Test
-    public void testEvolveDataFilters() {
+    public void testDevolveDataFilters() {
         List<Predicate> predicates = new ArrayList<>();
         predicates.add(
                 new LeafPredicate(

diff --git a/...nk-common/src/test/java/org/apache/paimon/flink/FilterPushdownWithSchemaChangeITCase.java b/...nk-common/src/test/java/org/apache/paimon/flink/FilterPushdownWithSchemaChangeITCase.java
@@ -18,6 +18,7 @@
 
 package org.apache.paimon.flink;
 
+import org.apache.paimon.casting.CastExecutors;
 import org.apache.paimon.testutils.junit.parameterized.ParameterizedTestExtension;
 import org.apache.paimon.testutils.junit.parameterized.Parameters;
 
@@ -31,7 +32,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-/** TODO all file format tests. */
+/** ITCase for {@link CastExecutors#safelyCastLiteralsWithNumericEvolution}. */
 @ExtendWith(ParameterizedTestExtension.class)
 public class FilterPushdownWithSchemaChangeITCase extends CatalogITCaseBase {