[core] Check bucket only cache enabled for scan in write

apache · Aug 11, 2024 · cd6808b · cd6808b
1 parent c4ef181
commit cd6808b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java b/paimon-core/src/main/java/org/apache/paimon/manifest/ManifestFile.java
@@ -192,6 +192,10 @@ public Factory(
             this.cache = cache;
         }
 
+        public boolean isCacheEnabled() {
+            return cache != null;
+        }
+
         public ManifestFile create() {
             RowType entryType = VersionedObjectSerializer.versionType(ManifestEntry.schema());
             return new ManifestFile(

diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreScan.java b/paimon-core/src/main/java/org/apache/paimon/operation/AbstractFileStoreScan.java
@@ -148,7 +148,7 @@ public FileStoreScan withBucketFilter(Filter<Integer> bucketFilter) {
 
     @Override
     public FileStoreScan withPartitionBucket(BinaryRow partition, int bucket) {
-        if (manifestCacheFilter != null) {
+        if (manifestCacheFilter != null && manifestFileFactory.isCacheEnabled()) {
             checkArgument(
                     manifestCacheFilter.test(partition, bucket),
                     String.format(

diff --git a/paimon-core/src/test/java/org/apache/paimon/utils/SnapshotManagerTest.java b/paimon-core/src/test/java/org/apache/paimon/utils/SnapshotManagerTest.java
@@ -30,12 +30,8 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
-import java.util.HashSet;
 import java.util.List;
-import java.util.Set;
-import java.util.concurrent.ThreadLocalRandom;
 import java.util.concurrent.atomic.AtomicReference;
-import java.util.stream.Collectors;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.fail;