Skip to content

Commit

Permalink
[minor] Add comments for tag without timeRetained
Browse files Browse the repository at this point in the history
  • Loading branch information
JingsongLi committed Jun 20, 2024
1 parent 9e98cda commit c46a256
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,11 @@ public void createTag(
} else {
Path newTagPath = tagPath(tagName);
try {
// When timeRetained is not defined, please do not write the tagCreatorTime field,
// as this will cause older versions (<= 0.7) of readers to be unable to read this
// tag.
// When timeRetained is defined, it is fine, because timeRetained is the new
// feature.
fileIO.writeFileUtf8(
newTagPath,
timeRetained != null
Expand Down

0 comments on commit c46a256

Please sign in to comment.