[core] Delete tag not failed if tag not exists (#4292)

apache · Oct 9, 2024 · ba98f31 · ba98f31
1 parent eed7896
commit ba98f31
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java b/paimon-core/src/main/java/org/apache/paimon/utils/TagManager.java
@@ -188,7 +188,10 @@ public void deleteTag(
             List<TagCallback> callbacks) {
         checkArgument(
                 !StringUtils.isNullOrWhitespaceOnly(tagName), "Tag name '%s' is blank.", tagName);
-        checkArgument(tagExists(tagName), "Tag '%s' doesn't exist.", tagName);
+        if (!tagExists(tagName)) {
+            LOG.warn("Tag '{}' doesn't exist.", tagName);
+            return;
+        }
 
         Snapshot taggedSnapshot = taggedSnapshot(tagName);
         List<Snapshot> taggedSnapshots;

diff --git a/paimon-core/src/test/java/org/apache/paimon/table/FileStoreTableTestBase.java b/paimon-core/src/test/java/org/apache/paimon/table/FileStoreTableTestBase.java
@@ -1425,10 +1425,7 @@ public void testDeleteTag() throws Exception {
         table.createTag("tag1", 1);
         table.deleteTag("tag1");
 
-        assertThatThrownBy(() -> table.deleteTag("tag1"))
-                .satisfies(
-                        anyCauseMatches(
-                                IllegalArgumentException.class, "Tag 'tag1' doesn't exist."));
+        assertThat(table.tagManager().tags().containsValue("tag1")).isFalse();
     }
 
     @Test

diff --git a/...on/src/test/scala/org/apache/paimon/spark/procedure/CreateAndDeleteTagProcedureTest.scala b/...on/src/test/scala/org/apache/paimon/spark/procedure/CreateAndDeleteTagProcedureTest.scala
@@ -191,4 +191,12 @@ class CreateAndDeleteTagProcedureTest extends PaimonSparkTestBase with StreamTes
       }
     }
   }
+
+  test("Paimon Procedure: delete tag not failed if tag not exists") {
+    spark.sql("CREATE TABLE T (id STRING, name STRING) USING PAIMON")
+
+    checkAnswer(
+      spark.sql("CALL paimon.sys.delete_tag(table => 'test.T', tag => 'test_tag')"),
+      Row(true) :: Nil)
+  }
 }