[build] Upgrade maven-jar-plugin: fixes Reproducible Builds issue 1 (#…

…3719)
apache · Jul 12, 2024 · a8c1b3d · a8c1b3d
1 parent 8fd462a
commit a8c1b3d
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 16 deletions.
diff --git a/paimon-filesystems/paimon-oss-impl/pom.xml b/paimon-filesystems/paimon-oss-impl/pom.xml
@@ -102,13 +102,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>jar</goal>
-                        </goals>
-                    </execution>
-                </executions>
                 <configuration>
                     <archive>
                         <manifestEntries>

diff --git a/paimon-filesystems/paimon-s3-impl/pom.xml b/paimon-filesystems/paimon-s3-impl/pom.xml
@@ -272,13 +272,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <executions>
-                    <execution>
-                        <goals>
-                            <goal>jar</goal>
-                        </goals>
-                    </execution>
-                </executions>
                 <configuration>
                     <archive>
                         <manifestEntries>

diff --git a/pom.xml b/pom.xml
@@ -343,12 +343,12 @@ under the License.
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
-                <version>2.4</version><!--$NO-MVN-MAN-VER$-->
+                <version>3.4.2</version><!--$NO-MVN-MAN-VER$-->
                 <configuration>
                     <archive>
                         <manifestEntries>
                             <SCM-Revision>${git.commit.id}</SCM-Revision>
-                            <SCM-Branch>${git.branch}</SCM-Branch>
+                            <SCM-Branch>${git.branch}</SCM-Branch><!-- TODO: remove this non-reproducible config once maven-jar-plugin upgrade works -->
                         </manifestEntries>
                         <manifest>
                             <addDefaultImplementationEntries>true</addDefaultImplementationEntries>