update

apache · Dec 10, 2024 · 8232c15 · 8232c15
1 parent 9767d5b
commit 8232c15
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java b/paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java
@@ -212,14 +212,16 @@ public TableSchema createTable(Schema schema, boolean externalTable) throws Exce
         while (true) {
             Optional<TableSchema> latest = latest();
             if (latest.isPresent()) {
-                if (externalTable && checkSchemaForExternalTable(latest.get(), schema)) {
-                    return latest.get();
+                TableSchema latestSchema = latest.get();
+                if (externalTable) {
+                    checkSchemaForExternalTable(latestSchema, schema);
+                    return latestSchema;
                 } else {
                     throw new IllegalStateException(
-                        "Schema in filesystem exists, creation is not allowed.");
+                            "Schema in filesystem exists, creation is not allowed.");
                 }
             }
-            
+
             List<DataField> fields = schema.fields();
             List<String> partitionKeys = schema.partitionKeys();
             List<String> primaryKeys = schema.primaryKeys();
@@ -246,7 +248,7 @@ public TableSchema createTable(Schema schema, boolean externalTable) throws Exce
         }
     }
 
-    private boolean checkSchemaForExternalTable(TableSchema existsSchema, Schema newSchema) {
+    private void checkSchemaForExternalTable(TableSchema existsSchema, Schema newSchema) {
         // When creating an external table, if the table already exists in the location, we can
         // choose not to specify the fields.
         if (newSchema.fields().isEmpty()
@@ -276,7 +278,6 @@ private boolean checkSchemaForExternalTable(TableSchema existsSchema, Schema new
                             + ", exists schema: "
                             + existsSchema);
         }
-        return true;
     }
 
     /** Update {@link SchemaChange}s. */