[core] fix the problem that RecordReader may not be closed in asynchr…

…onous compact thread. (#2309)
apache · Nov 13, 2023 · 6fb34fb · 6fb34fb
1 parent c9cf20a
commit 6fb34fb
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/paimon-common/src/main/java/org/apache/paimon/reader/RecordReaderIterator.java b/paimon-common/src/main/java/org/apache/paimon/reader/RecordReaderIterator.java
@@ -76,6 +76,9 @@ private void advanceIfNeeded() {
                     break;
                 } else {
                     currentIterator.releaseBatch();
+                    // because reader#readBatch will be affected by interrupt, which will cause
+                    // currentIterator#releaseBatch to be executed twice.
+                    currentIterator = null;
                     currentIterator = reader.readBatch();
                     if (currentIterator == null) {
                         break;
@@ -89,9 +92,12 @@ private void advanceIfNeeded() {
 
     @Override
     public void close() throws Exception {
-        if (currentIterator != null) {
-            currentIterator.releaseBatch();
+        try {
+            if (currentIterator != null) {
+                currentIterator.releaseBatch();
+            }
+        } finally {
+            reader.close();
         }
-        reader.close();
     }
 }