[core] Check bucket-key cannot be nested types (#3949)

apache · Aug 13, 2024 · 65df3f9 · 65df3f9
1 parent ab14a13
commit 65df3f9
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java b/paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java
@@ -69,6 +69,10 @@
 import static org.apache.paimon.mergetree.compact.PartialUpdateMergeFunction.SEQUENCE_GROUP;
 import static org.apache.paimon.schema.SystemColumns.KEY_FIELD_PREFIX;
 import static org.apache.paimon.schema.SystemColumns.SYSTEM_FIELD_NAMES;
+import static org.apache.paimon.types.DataTypeRoot.ARRAY;
+import static org.apache.paimon.types.DataTypeRoot.MAP;
+import static org.apache.paimon.types.DataTypeRoot.MULTISET;
+import static org.apache.paimon.types.DataTypeRoot.ROW;
 import static org.apache.paimon.utils.Preconditions.checkArgument;
 import static org.apache.paimon.utils.Preconditions.checkState;
 
@@ -564,6 +568,29 @@ private static void validateBucket(TableSchema schema, CoreOptions options) {
                 throw new RuntimeException(
                         "You should define a 'bucket-key' for bucketed append mode.");
             }
+
+            if (!schema.bucketKeys().isEmpty()) {
+                List<String> bucketKeys = schema.bucketKeys();
+                List<String> nestedFields =
+                        schema.fields().stream()
+                                .filter(
+                                        dataField ->
+                                                bucketKeys.contains(dataField.name())
+                                                        && (dataField.type().getTypeRoot() == ARRAY
+                                                                || dataField.type().getTypeRoot()
+                                                                        == MULTISET
+                                                                || dataField.type().getTypeRoot()
+                                                                        == MAP
+                                                                || dataField.type().getTypeRoot()
+                                                                        == ROW))
+                                .map(dataField -> dataField.name())
+                                .collect(Collectors.toList());
+                if (nestedFields.size() > 0) {
+                    throw new RuntimeException(
+                            "nested type can not in bucket-key, in your table these key are "
+                                    + nestedFields.toString());
+                }
+            }
         }
     }
 }
diff --git a/...link/paimon-flink-common/src/test/java/org/apache/paimon/flink/AppendOnlyTableITCase.java b/...link/paimon-flink-common/src/test/java/org/apache/paimon/flink/AppendOnlyTableITCase.java
@@ -35,6 +35,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 /** Test case for append-only managed table. */
 public class AppendOnlyTableITCase extends CatalogITCaseBase {
@@ -230,6 +231,16 @@ public void testComplexType() {
         assertThat(batchSql("SELECT * FROM complex_table")).containsExactly(Row.of(1, null));
     }
 
+    @Test
+    public void testNestedTypeDDL() {
+        assertThrows(
+                RuntimeException.class,
+                () ->
+                        batchSql(
+                                "CREATE TABLE IF NOT EXISTS nested_table (id INT, data MAP<INT, INT>) WITH ('bucket' = '1', 'bucket-key'='id,data')"),
+                "nested type can not in bucket-key, in your table these key are [data]");
+    }
+
     @Test
     public void testTimestampLzType() {
         sql("CREATE TABLE t_table (id INT, data TIMESTAMP_LTZ(3))");