fix

apache · Apr 18, 2024 · 5af360a · 5af360a
1 parent e710b5c
commit 5af360a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 12 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java b/paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java
@@ -301,7 +301,7 @@ public ExpireSnapshots newExpireSnapshots(CoreOptions options) {
                 options.changelogNumRetainMax(),
                 options.changelogNumRetainMin(),
                 options.changelogTimeRetain().toMillis(),
-                options.snapshotExpireLimit()) {};
+                options.snapshotExpireLimit());
     }
 
     @Override

diff --git a/...ommon/src/test/scala/org/apache/paimon/spark/procedure/ExpireSnapshotsProcedureTest.scala b/...ommon/src/test/scala/org/apache/paimon/spark/procedure/ExpireSnapshotsProcedureTest.scala
@@ -19,10 +19,9 @@
 package org.apache.paimon.spark.procedure
 
 import org.apache.paimon.spark.PaimonSparkTestBase
-
-import org.apache.spark.sql.{Dataset, Row}
 import org.apache.spark.sql.execution.streaming.MemoryStream
 import org.apache.spark.sql.streaming.StreamTest
+import org.apache.spark.sql.{Dataset, Row}
 
 class ExpireSnapshotsProcedureTest extends PaimonSparkTestBase with StreamTest {
 
@@ -33,10 +32,11 @@ class ExpireSnapshotsProcedureTest extends PaimonSparkTestBase with StreamTest {
       withTempDir {
         checkpointDir =>
           // define a change-log table and test `forEachBatch` api
-          spark.sql(s"""
-                       |CREATE TABLE T (a INT, b STRING)
-                       |TBLPROPERTIES ('primary-key'='a', 'bucket'='3')
-                       |""".stripMargin)
+          spark.sql(
+            s"""
+               |CREATE TABLE T (a INT, b STRING)
+               |TBLPROPERTIES ('primary-key'='a', 'bucket'='3')
+               |""".stripMargin)
           val location = loadTable("T").location().toString
 
           val inputData = MemoryStream[(Int, String)]
@@ -71,7 +71,7 @@ class ExpireSnapshotsProcedureTest extends PaimonSparkTestBase with StreamTest {
 
             // expire
             checkAnswer(
-              spark.sql("CALL paimon.sys.expire_snapshots(table => 'test.T', retain_max => 2)"),
+              spark.sql("CALL paimon.sys.expire_snapshots(table => 'test.T', retain_max => 2, retain_min => 1)"),
               Row(1) :: Nil)
 
             checkAnswer(
@@ -89,10 +89,11 @@ class ExpireSnapshotsProcedureTest extends PaimonSparkTestBase with StreamTest {
       withTempDir {
         checkpointDir =>
           // define a change-log table and test `forEachBatch` api
-          spark.sql(s"""
-                       |CREATE TABLE T (a INT, b STRING)
-                       |TBLPROPERTIES ('primary-key'='a', 'bucket'='3')
-                       |""".stripMargin)
+          spark.sql(
+            s"""
+               |CREATE TABLE T (a INT, b STRING)
+               |TBLPROPERTIES ('primary-key'='a', 'bucket'='3')
+               |""".stripMargin)
           val location = loadTable("T").location().toString
 
           val inputData = MemoryStream[(Int, String)]