fixed

apache · Mar 1, 2024 · 558025f · 558025f
1 parent fec51fd
commit 558025f
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/...on/jdbc/AbstractDistributedLockTable.java → .../jdbc/AbstractDistributedLockDialect.java b/...on/jdbc/AbstractDistributedLockTable.java → .../jdbc/AbstractDistributedLockDialect.java
@@ -24,7 +24,7 @@
 import java.sql.SQLException;
 
 /** Jdbc distributed lock interface. */
-public abstract class AbstractDistributedLockTable implements JdbcDistributedLockTable {
+public abstract class AbstractDistributedLockDialect implements JdbcDistributedLockDialect {
 
     @Override
     public void createTable(JdbcClientPool connections) throws SQLException, InterruptedException {

diff --git a/...e/paimon/jdbc/DistributedLockFactory.java → ...n/jdbc/DistributedLockDialectFactory.java b/...e/paimon/jdbc/DistributedLockFactory.java → ...n/jdbc/DistributedLockDialectFactory.java
@@ -18,14 +18,14 @@
 
 package org.apache.paimon.jdbc;
 
-class DistributedLockFactory {
-    static JdbcDistributedLockTable create(String protocol) {
+class DistributedLockDialectFactory {
+    static JdbcDistributedLockDialect create(String protocol) {
         JdbcProtocol type = JdbcProtocol.valueOf(protocol.toUpperCase());
         switch (type) {
             case SQLITE:
-                return new SqlLiteDistributedLockTable();
+                return new SqlLiteDistributedLockDialect();
             case MYSQL:
-                return new MysqlDistributedLockTable();
+                return new MysqlDistributedLockDialect();
             default:
                 throw new UnsupportedOperationException(
                         String.format("Distributed locks based on %s are not supported", protocol));

diff --git a/...paimon/jdbc/JdbcDistributedLockTable.java → ...imon/jdbc/JdbcDistributedLockDialect.java b/...paimon/jdbc/JdbcDistributedLockTable.java → ...imon/jdbc/JdbcDistributedLockDialect.java
@@ -21,7 +21,7 @@
 import java.sql.SQLException;
 
 /** Jdbc distributed lock interface. */
-public interface JdbcDistributedLockTable {
+public interface JdbcDistributedLockDialect {
     void createTable(JdbcClientPool connections) throws SQLException, InterruptedException;
 
     boolean lockAcquire(JdbcClientPool connections, String lockId, long timeoutMillSeconds)

diff --git a/paimon-core/src/main/java/org/apache/paimon/jdbc/JdbcUtils.java b/paimon-core/src/main/java/org/apache/paimon/jdbc/JdbcUtils.java
@@ -407,14 +407,14 @@ private static String insertPropertiesStatement(int size) {
 
     public static void createDistributedLockTable(JdbcClientPool connections)
             throws SQLException, InterruptedException {
-        DistributedLockFactory.create(connections.getProtocol()).createTable(connections);
+        DistributedLockDialectFactory.create(connections.getProtocol()).createTable(connections);
     }
 
     public static boolean acquire(
             JdbcClientPool connections, String lockId, long timeoutMillSeconds)
             throws SQLException, InterruptedException {
-        JdbcDistributedLockTable jdbcDistributedLockTable =
-                DistributedLockFactory.create(connections.getProtocol());
+        JdbcDistributedLockDialect jdbcDistributedLockTable =
+                DistributedLockDialectFactory.create(connections.getProtocol());
         // Check and clear expire lock.
         int affectedRows = jdbcDistributedLockTable.tryReleaseTimedOutLock(connections, lockId);
         if (affectedRows > 0) {
@@ -425,6 +425,7 @@ public static boolean acquire(
 
     public static void release(JdbcClientPool connections, String lockId)
             throws SQLException, InterruptedException {
-        DistributedLockFactory.create(connections.getProtocol()).releaseLock(connections, lockId);
+        DistributedLockDialectFactory.create(connections.getProtocol())
+                .releaseLock(connections, lockId);
     }
 }
diff --git a/...aimon/jdbc/MysqlDistributedLockTable.java → ...mon/jdbc/MysqlDistributedLockDialect.java b/...aimon/jdbc/MysqlDistributedLockTable.java → ...mon/jdbc/MysqlDistributedLockDialect.java
@@ -19,7 +19,7 @@
 package org.apache.paimon.jdbc;
 
 /** Distributed lock implementation based on sqlite table. */
-public class MysqlDistributedLockTable extends AbstractDistributedLockTable {
+public class MysqlDistributedLockDialect extends AbstractDistributedLockDialect {
 
     @Override
     public String getCreateTableSql() {

diff --git a/...mon/jdbc/SqlLiteDistributedLockTable.java → ...n/jdbc/SqlLiteDistributedLockDialect.java b/...mon/jdbc/SqlLiteDistributedLockTable.java → ...n/jdbc/SqlLiteDistributedLockDialect.java
@@ -19,7 +19,7 @@
 package org.apache.paimon.jdbc;
 
 /** Distributed lock implementation based on sqlite table. */
-public class SqlLiteDistributedLockTable extends AbstractDistributedLockTable {
+public class SqlLiteDistributedLockDialect extends AbstractDistributedLockDialect {
 
     @Override
     public String getCreateTableSql() {