[core] Avoid hashbytes twice in HashLookupStoreReader

apache · Jan 24, 2024 · 4cbd24d · 4cbd24d
1 parent 3d8f14b
commit 4cbd24d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/paimon-common/src/main/java/org/apache/paimon/lookup/hash/HashLookupStoreReader.java b/paimon-common/src/main/java/org/apache/paimon/lookup/hash/HashLookupStoreReader.java
@@ -178,18 +178,19 @@ public byte[] lookup(byte[] key) throws IOException {
             return null;
         }
 
-        if (bloomFilter != null && !bloomFilter.testHash(MurmurHashUtils.hashBytes(key))) {
+        int hashcode = MurmurHashUtils.hashBytes(key);
+        if (bloomFilter != null && !bloomFilter.testHash(hashcode)) {
             return null;
         }
 
-        long hash = MurmurHashUtils.hashBytesPositive(key);
+        long hashPositive = hashcode & 0x7fffffff;
         int numSlots = slots[keyLength];
         int slotSize = slotSizes[keyLength];
         int indexOffset = indexOffsets[keyLength];
         long dataOffset = dataOffsets[keyLength];
 
         for (int probe = 0; probe < numSlots; probe++) {
-            long slot = (hash + probe) % numSlots;
+            long slot = (hashPositive + probe) % numSlots;
             inputView.setReadPosition(indexOffset + slot * slotSize);
             inputView.readFully(slotBuffer, 0, slotSize);