update desc of METASTORE_PARTITIONED and update ut

dropPartition throw exception when table is nul
apache · Dec 30, 2024 · 427f5a7 · 427f5a7
1 parent 1dfe8eb
commit 427f5a7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java b/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalog.java
@@ -398,6 +398,8 @@ public void dropPartition(Identifier identifier, Map<String, String> partitions)
         Table table = getTable(identifier);
         if (table != null) {
             cleanPartitionsInFileSystem(table, partitions);
+        } else {
+            throw new TableNotExistException(identifier);
         }
     }
 

diff --git a/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalogOptions.java b/paimon-core/src/main/java/org/apache/paimon/rest/RESTCatalogOptions.java
@@ -76,5 +76,5 @@ public class RESTCatalogOptions {
             ConfigOptions.key("metastore-partitioned")
                     .booleanType()
                     .defaultValue(false)
-                    .withDescription("REST Catalog whether support list partitions.");
+                    .withDescription("REST Catalog Server whether support list partitions.");
 }
diff --git a/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogTest.java b/paimon-core/src/test/java/org/apache/paimon/rest/RESTCatalogTest.java
@@ -402,7 +402,7 @@ public void testDropPartition() throws Exception {
         Map<String, String> partitionSpec = new HashMap<>();
         GetTableResponse response = MockRESTMessage.getTableResponse();
         partitionSpec.put(response.getSchema().primaryKeys().get(0), "1");
-        mockResponse(mapper.writeValueAsString(new SuccessResponse()), 200);
+        mockResponse(mapper.writeValueAsString(""), 200);
         mockResponse(mapper.writeValueAsString(response), 200);
         doNothing().when(mockRestCatalog).cleanPartitionsInFileSystem(any(), any());
         assertDoesNotThrow(
@@ -420,7 +420,7 @@ public void testDropPartitionWhenPartitionNoExist() throws Exception {
         Map<String, String> partitionSpec = new HashMap<>();
         GetTableResponse response = MockRESTMessage.getTableResponse();
         partitionSpec.put(response.getSchema().primaryKeys().get(0), "1");
-        mockResponse(mapper.writeValueAsString(new SuccessResponse()), 404);
+        mockResponse(mapper.writeValueAsString(""), 404);
         mockResponse(mapper.writeValueAsString(response), 200);
         doNothing().when(mockRestCatalog).cleanPartitionsInFileSystem(any(), any());
         assertDoesNotThrow(
@@ -438,7 +438,7 @@ public void testDropPartitionWhenTableNoPermission() throws Exception {
         Map<String, String> partitionSpec = new HashMap<>();
         GetTableResponse response = MockRESTMessage.getTableResponse();
         partitionSpec.put(response.getSchema().primaryKeys().get(0), "1");
-        mockResponse(mapper.writeValueAsString(new SuccessResponse()), 403);
+        mockResponse(mapper.writeValueAsString(""), 403);
         doNothing().when(mockRestCatalog).cleanPartitionsInFileSystem(any(), any());
         assertThrows(
                 Catalog.TableNoPermissionException.class,