fix comment

apache · Dec 10, 2024 · 4124716 · 4124716
1 parent fe09553
commit 4124716
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/mergetree/MergeTreeWriter.java b/paimon-core/src/main/java/org/apache/paimon/mergetree/MergeTreeWriter.java
@@ -96,8 +96,6 @@ public MergeTreeWriter(
             long maxSequenceNumber,
             Comparator<InternalRow> keyComparator,
             MergeFunction<KeyValue> mergeFunction,
-            RowType keyType,
-            RowType valueType,
             KeyValueFileWriterFactory writerFactory,
             boolean commitForceCompact,
             ChangelogProducer changelogProducer,
@@ -108,8 +106,8 @@ public MergeTreeWriter(
         this.sortMaxFan = sortMaxFan;
         this.sortCompression = sortCompression;
         this.ioManager = ioManager;
-        this.keyType = keyType;
-        this.valueType = valueType;
+        this.keyType = writerFactory.keyType();
+        this.valueType = writerFactory.valueType();
         this.compactManager = compactManager;
         this.newSequenceNumber = maxSequenceNumber + 1;
         this.keyComparator = keyComparator;

diff --git a/paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreWrite.java b/paimon-core/src/main/java/org/apache/paimon/operation/KeyValueFileStoreWrite.java
@@ -220,8 +220,6 @@ protected MergeTreeWriter createWriter(
                 restoredMaxSeqNumber,
                 keyComparator,
                 mfFactory.create(),
-                keyType,
-                valueType,
                 writerFactory,
                 options.commitForceCompact(),
                 options.changelogProducer(),

diff --git a/paimon-core/src/test/java/org/apache/paimon/mergetree/MergeTreeTestBase.java b/paimon-core/src/test/java/org/apache/paimon/mergetree/MergeTreeTestBase.java
@@ -514,8 +514,6 @@ private MergeTreeWriter createMergeTreeWriter(
                         maxSequenceNumber,
                         comparator,
                         DeduplicateMergeFunction.factory().create(),
-                        writerFactory.keyType(),
-                        writerFactory.valueType(),
                         writerFactory,
                         options.commitForceCompact(),
                         changelogProducer,