Skip to content

Commit

Permalink
[core] Rename to compactDvIndexFiles in FileStoreCommitImpl
Browse files Browse the repository at this point in the history
  • Loading branch information
JingsongLi committed Mar 28, 2024
1 parent 4d5e676 commit 2407353
Showing 1 changed file with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -221,15 +221,15 @@ public void commit(ManifestCommittable committable, Map<String, String> properti
List<ManifestEntry> compactTableFiles = new ArrayList<>();
List<ManifestEntry> compactChangelog = new ArrayList<>();
List<IndexManifestEntry> appendHashIndexFiles = new ArrayList<>();
List<IndexManifestEntry> appendDvIndexFiles = new ArrayList<>();
List<IndexManifestEntry> compactDvIndexFiles = new ArrayList<>();
collectChanges(
committable.fileCommittables(),
appendTableFiles,
appendChangelog,
compactTableFiles,
compactChangelog,
appendHashIndexFiles,
appendDvIndexFiles);
compactDvIndexFiles);
try {
List<SimpleFileEntry> appendSimpleEntries = SimpleFileEntry.from(appendTableFiles);
if (!ignoreEmptyCommit
Expand Down Expand Up @@ -272,7 +272,7 @@ public void commit(ManifestCommittable committable, Map<String, String> properti

if (!compactTableFiles.isEmpty()
|| !compactChangelog.isEmpty()
|| !appendDvIndexFiles.isEmpty()) {
|| !compactDvIndexFiles.isEmpty()) {
// Optimization for common path.
// Step 2:
// Add appendChanges to the manifest entries read above and check for conflicts.
Expand All @@ -294,7 +294,7 @@ public void commit(ManifestCommittable committable, Map<String, String> properti
tryCommit(
compactTableFiles,
compactChangelog,
appendDvIndexFiles,
compactDvIndexFiles,
committable.identifier(),
committable.watermark(),
committable.logOffsets(),
Expand Down Expand Up @@ -360,15 +360,15 @@ public void overwrite(
List<ManifestEntry> compactTableFiles = new ArrayList<>();
List<ManifestEntry> compactChangelog = new ArrayList<>();
List<IndexManifestEntry> appendHashIndexFiles = new ArrayList<>();
List<IndexManifestEntry> appendDvIndexFiles = new ArrayList<>();
List<IndexManifestEntry> compactDvIndexFiles = new ArrayList<>();
collectChanges(
committable.fileCommittables(),
appendTableFiles,
appendChangelog,
compactTableFiles,
compactChangelog,
appendHashIndexFiles,
appendDvIndexFiles);
compactDvIndexFiles);

if (!appendChangelog.isEmpty() || !compactChangelog.isEmpty()) {
StringBuilder warnMessage =
Expand Down Expand Up @@ -437,12 +437,12 @@ public void overwrite(
generatedSnapshot += 1;
}

if (!compactTableFiles.isEmpty() || !appendDvIndexFiles.isEmpty()) {
if (!compactTableFiles.isEmpty() || !compactDvIndexFiles.isEmpty()) {
attempts +=
tryCommit(
compactTableFiles,
Collections.emptyList(),
appendDvIndexFiles,
compactDvIndexFiles,
committable.identifier(),
committable.watermark(),
committable.logOffsets(),
Expand Down Expand Up @@ -565,7 +565,7 @@ private void collectChanges(
List<ManifestEntry> compactTableFiles,
List<ManifestEntry> compactChangelog,
List<IndexManifestEntry> appendHashIndexFiles,
List<IndexManifestEntry> appendDvIndexFiles) {
List<IndexManifestEntry> compactDvIndexFiles) {
for (CommitMessage message : commitMessages) {
CommitMessageImpl commitMessage = (CommitMessageImpl) message;
commitMessage
Expand Down Expand Up @@ -606,7 +606,7 @@ private void collectChanges(
f));
break;
case DELETION_VECTORS_INDEX:
appendDvIndexFiles.add(
compactDvIndexFiles.add(
new IndexManifestEntry(
FileKind.ADD,
commitMessage.partition(),
Expand Down

0 comments on commit 2407353

Please sign in to comment.