Introduce compactionDropDeletedRecordCount metric.

apache · Nov 11, 2024 · 22edb4f · 22edb4f
1 parent 7dae1ad
commit 22edb4f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/paimon-core/src/main/java/org/apache/paimon/compact/CompactTask.java b/paimon-core/src/main/java/org/apache/paimon/compact/CompactTask.java
@@ -64,8 +64,7 @@ public CompactResult call() throws Exception {
                                             .map(DataFileMeta::fileSize)
                                             .reduce(Long::sum)
                                             .orElse(0L));
-                            metricsReporter.reportDropDeletedRecordCount(
-                                    result.getDropDeletedRecordCount());
+                            reportDropDeletedRecordCount(result.getDropDeletedRecordCount());
                         }
                     },
                     LOG);
@@ -80,6 +79,12 @@ public CompactResult call() throws Exception {
         }
     }
 
+    private void reportDropDeletedRecordCount(long dropDeletedRecordCount) {
+        if (metricsReporter != null) {
+            metricsReporter.reportDropDeletedRecordCount(dropDeletedRecordCount);
+        }
+    }
+
     private void decreaseCompactionsQueuedCount() {
         if (metricsReporter != null) {
             metricsReporter.decreaseCompactionsQueuedCount();

diff --git a/paimon-core/src/main/java/org/apache/paimon/mergetree/DropDeleteReader.java b/paimon-core/src/main/java/org/apache/paimon/mergetree/DropDeleteReader.java
@@ -32,7 +32,7 @@
  */
 public class DropDeleteReader implements RecordReader<KeyValue> {
 
-    private long dropDeletedRecordCount = 0L;
+    private long dropDeleteRecordCount = 0L;
     private final RecordReader<KeyValue> reader;
 
     public DropDeleteReader(RecordReader<KeyValue> reader) {
@@ -59,7 +59,7 @@ public KeyValue next() throws IOException {
                     if (kv.isAdd()) {
                         return kv;
                     }
-                    ++dropDeletedRecordCount;
+                    ++dropDeleteRecordCount;
                 }
             }
 
@@ -72,7 +72,7 @@ public void releaseBatch() {
 
     @Override
     public long skippedRecordCount() {
-        return dropDeletedRecordCount;
+        return dropDeleteRecordCount;
     }
 
     @Override