Skip to content

Commit

Permalink
improve
Browse files Browse the repository at this point in the history
  • Loading branch information
wg1026688210 committed Feb 28, 2024
1 parent 635bae2 commit 1d80aac
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
import org.apache.paimon.data.InternalRow;
import org.apache.paimon.utils.ObjectSerializer;

/** Serializer for {@link Identifier}.*/
/** Serializer for {@link Identifier}. */
public class IdentifierSerializer extends ObjectSerializer<Identifier> {

public IdentifierSerializer() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@ private void buildForCombinedMode() {
excludingPattern,
tableOptions.get(CoreOptions.CONTINUOUS_DISCOVERY_INTERVAL).toMillis());

// multi bucket table which has multi bucket in a partition like fix bucket and dynamic bucket
// multi bucket table which has multi bucket in a partition like fix bucket and dynamic
// bucket
DataStream<RowData> multiBucketTableSource =
partition(
sourceBuilder
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,14 @@
import static org.apache.paimon.flink.utils.MultiTablesCompactorUtil.shouldCompactTable;

/**
* This class is responsible for implementing the scanning logic for the table of different type buckets during
* compaction.
* This class is responsible for implementing the scanning logic for the table of different type
* buckets during compaction.
*
* @param <T> the result of scanning file :
* <ol>
* <li>{@link Split} for the table with multi buckets, such as dynamic or fixed
* bucket table.
* <li>{@link AppendOnlyCompactionTask} for the table witch fixed single
* bucket ,such as unaware bucket table.
* <li>{@link Split} for the table with multi buckets, such as dynamic or fixed bucket table.
* <li>{@link AppendOnlyCompactionTask} for the table witch fixed single bucket ,such as
* unaware bucket table.
* </ol>
*/
public abstract class AbstractBucketScanLogic<T> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,11 @@ public void scan(SourceFunction.SourceContext<T> ctx) throws Exception {
return;
}
if (isEmpty) {
// Currently, in the combined mode, there are two scan tasks for the table of two different bucket type (multi bucket & unaware bucket) are
// Currently, in the combined mode, there are two scan tasks for the table of two
// different bucket type (multi bucket & unaware bucket) are
// running concurrently.
// There will be a situation that there is only one task compaction , therefore this should not be thrown exception here.
// There will be a situation that there is only one task compaction , therefore this
// should not be thrown exception here.
LOGGER.info(
"No file were collected for the table of {}", tableScanLogic.bucketType());
}
Expand Down

0 comments on commit 1d80aac

Please sign in to comment.