HDDS-12050. Implement TransactionInfoRepair command for SCM

[sarvekshayr]

What changes were proposed in this pull request?

ozone repair scm update-transaction
A port of the existing ozone repair om update-transaction for SCM.

What is the link to the Apache JIRA

HDDS-12050

How was this patch tested?

Tested the patch on a docker cluster.

bash-5.1$ ozone repair scm
Missing required subcommand
Usage: ozone repair scm [COMMAND]
Operational tool to repair SCM.
Commands:
  cert                Subcommand for all certificate related repairs on SCM
  update-transaction  CLI to update the highest index in scmTransactionInfos
                        table.

bash-5.1$ ozone repair scm update-transaction --db /data/metadata/scm.db --term 2 --index 2
ATTENTION: Running as user hadoop. Make sure this is the same user used to run the Ozone process. Are you sure you want to continue (y/N)? y
Run as user: hadoop
Error: SCM is currently running on this host with PID 7. Stop the service before running the repair tool.

[adoroszlai]

Thanks @sarvekshayr for the patch.

I would like to avoid copying logic for SCM's version of the tool. Here's my attempt to reduce duplication: adoroszlai@29fd408, which results in smaller diff: master...adoroszlai:ozone:HDDS-12050

[sarvekshayr]

I would like to avoid copying logic for SCM's version of the tool. Here's my attempt to reduce duplication: adoroszlai@29fd408, which results in smaller diff: master...adoroszlai:ozone:HDDS-12050

Thank you @adoroszlai. The change proposed is simpler, reduces duplication and the patch looks good overall.
We can commit the change.

[adoroszlai]

The change proposed is simpler, reduces duplication and the patch looks good overall. We can commit the change.

Thanks, I've added my commits to this PR.

[adoroszlai]

@errose28 could you please review?

[adoroszlai]

@nandakumar131 please review if you have some time

[Tejaskriya]

Thanks for working on this @sarvekshayr , Could we add a test under the integration test TestOzoneRepairShell for testing scm component as well? (there is testUpdateTransactionInfoTable testing for om already)

[sarvekshayr]

Thanks for working on this @sarvekshayr , Could we add a test under the integration test TestOzoneRepairShell for testing scm component as well? (there is testUpdateTransactionInfoTable testing for om already)

Sure, I'll modify it to test scm component as well.