Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tune Dependabot config #687

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

mawiesne
Copy link
Contributor

@mawiesne mawiesne commented Nov 17, 2024

Change

  • Adjusts Dependabot to only consider major/minor version updates for some dependencies

Tasks

Thank you for contributing to Apache OpenNLP.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.

@mawiesne mawiesne requested review from rzo1 and kinow November 17, 2024 10:32
@mawiesne mawiesne force-pushed the adjust-dependabot-to-ignore-some-minor-versions branch from e025414 to 7f720bf Compare November 17, 2024 10:34
@mawiesne mawiesne added the github_actions Pull requests that update GitHub Actions code label Nov 17, 2024
@mawiesne mawiesne changed the title Adjust Dependabot to only consider major version updates for some dependencies Fine-tune Dependabot config Nov 17, 2024
Copy link
Contributor

@rzo1 rzo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PuppyCrawl 😁😄🔥

@mawiesne mawiesne merged commit 3feb420 into main Nov 17, 2024
15 checks passed
@mawiesne mawiesne deleted the adjust-dependabot-to-ignore-some-minor-versions branch November 17, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants