Update mvnw and CI on JDK 21 #80
Conversation
| @@ -14,6 +14,6 @@ | |||
| # KIND, either express or implied. See the License for the | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.6/apache-maven-3.9.6-bin.zip | |||
| wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar | |||
| distributionSha256Sum=83aaf914c785c9faed661f223000a92d1de9553f5c82d3b4362e66d9c031625f | |||
There was a problem hiding this comment.
Please don't remove the hash. Will need regenerating, and mvnw might also need patching to pass on macOS - see https://issues.apache.org/jira/browse/MWRAPPER-150
There was a problem hiding this comment.
this wasn't intended. I simply ran the mvnw updater. Will fix it.
There was a problem hiding this comment.
Yes, it's annoying it doesn't handle this. And that it uses sha256 so the hashes aren't published anywhere. I've just got in the habit of patching these files manually. Thanks for looking at this!
There was a problem hiding this comment.
btw do you want to keep the wrapperUrl property too? the wrapper did remove that one also.
There was a problem hiding this comment.
No, that's unused IIRC. Should have removed it when I last updated this.
No description provided.