Upgrade non-external repos before loading packages #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to this, we will upgrade external repos to proper versions, instead of always upgrading them to versions set in pkg files from master branches of non-external repos. I.e. if mynewt-core will be upgraded to version 1.11.0, external repos included in mynewt-core pkg.yml files are going be downloaded and upgraded as specified in those files from mynewt_1_11_0_tag. Without this external repos included in mynewt-core would be upgraded to versions specified in pkgs from mynewt-core's master branch, which would lead to versions mismatch and probably compilation errors
sjanc
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to this, we will upgrade external repos to proper versions, instead of always upgrading them to versions set in pkg files from master branches of non-external repos.
I.e. if mynewt-core will be upgraded to version 1.11.0, external repos included in mynewt-core pkg.yml files are going be downloaded and upgraded as specified
in those files from mynewt_1_11_0_tag. Without this external repos included in mynewt-core would be upgraded to versions specified in pkgs from mynewt-core's
master branch, which would lead to versions mismatch and probably compilation errors