-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-8524] DefaultInterpolator should be used by injection #2049
base: master
Are you sure you want to change the base?
Conversation
.../maven-cli/src/main/java/org/apache/maven/cling/extensions/ExtensionConfigurationModule.java
Outdated
Show resolved
Hide resolved
I'm not sure we want to change the maven 3 code base too much. I've tried to revert most changes to get back into a compatible state, so if we add a constructor, it might break something. And for not much value, as this code is not really used. |
Agreed, the compat/maven-embedder changes should be undone. |
There are two references to
We can simply inline those constructors, as they are only used in a few tests. This will move the references to the implementation to the tests instead of the main code. |
Signed-off-by: crazyhzm <[email protected]>
@gnodet Done. |
JIRA Issue: [MNG-8524]