Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8524] DefaultInterpolator should be used by injection #2049

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Jan 15, 2025

JIRA Issue: [MNG-8524]

@gnodet
Copy link
Contributor

gnodet commented Jan 15, 2025

I'm not sure we want to change the maven 3 code base too much. I've tried to revert most changes to get back into a compatible state, so if we add a constructor, it might break something. And for not much value, as this code is not really used.

@cstamas
Copy link
Member

cstamas commented Jan 15, 2025

Agreed, the compat/maven-embedder changes should be undone.

@cstamas cstamas added this to the 4.0.0-rc-3 milestone Jan 15, 2025
@CrazyHZM
Copy link
Member Author

@gnodet @cstamas I also agree with this and have reverted the compatibility logic of maven3.

@gnodet
Copy link
Contributor

gnodet commented Jan 17, 2025

There are two references to new DefaultInterpolator() that can be easily removed:

We can simply inline those constructors, as they are only used in a few tests. This will move the references to the implementation to the tests instead of the main code.

@CrazyHZM
Copy link
Member Author

There are two references to new DefaultInterpolator() that can be easily removed:

We can simply inline those constructors, as they are only used in a few tests. This will move the references to the implementation to the tests instead of the main code.

@gnodet Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants