[MJLINK-84] Remove remaining commons-lang3 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency to commons-lang3 has been removed earlier on, but still there were usages of `StringUtils` & `SystemUtils` which lead to the plugin requiring the dependency to be added explicitly when used. Follows: apache#167
elharo
requested changes
Dec 2, 2024
| @@ -172,7 +169,7 @@ private int executeCommand(Commandline cmd) throws MojoExecutionException { | |||
|
|
|||
| StringBuilder msg = new StringBuilder("\nExit code: "); | |||
| msg.append(exitCode); | |||
| if (StringUtils.isNotEmpty(err.getOutput())) { | |||
| if (!err.getOutput().isBlank()) { | |||
There was a problem hiding this comment.
This requires Java 11. I think we want to allow Java 8.
| @@ -193,4 +190,18 @@ private int executeCommand(Commandline cmd) throws MojoExecutionException { | |||
| throw new MojoExecutionException("Unable to execute jlink command: " + e.getMessage(), e); | |||
| } | |||
| } | |||
|
|
|||
| private static boolean isOSWindows() { | |||
| String osName; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency to commons-lang3 has been removed earlier on, but still there were usages of
StringUtils&SystemUtilswhich lead to the plugin requiring the dependency to be added explicitly when used.Follows: #167
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MJLINK-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MJLINK-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.