MJLINK-86: --suggested-providers must be the last argument

apache · Nov 19, 2024 · 5988ffe · 5988ffe
1 parent 2cd2747
commit 5988ffe
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java b/src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
@@ -704,12 +704,6 @@ protected List<String> createJlinkArgs(Collection<String> pathsOfModules, Collec
             jlinkArgs.add("--no-man-pages");
         }
 
-        if (hasSuggestProviders()) {
-            jlinkArgs.add("--suggest-providers");
-            String sb = getCommaSeparatedList(suggestProviders);
-            jlinkArgs.add(sb);
-        }
-
         if (hasLimitModules()) {
             jlinkArgs.add("--limit-modules");
             String sb = getCommaSeparatedList(limitModules);
@@ -747,6 +741,13 @@ protected List<String> createJlinkArgs(Collection<String> pathsOfModules, Collec
             jlinkArgs.add("--verbose");
         }
 
+        // NOTE: suggestProviders is a terminal JlinkTask, so must be at the end!
+        if (hasSuggestProviders()) {
+            jlinkArgs.add("--suggest-providers");
+            String sb = getCommaSeparatedList(suggestProviders);
+            jlinkArgs.add(sb);
+        }
+
         return Collections.unmodifiableList(jlinkArgs);
     }