Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ubuntu build to 22.04 due to .NET 5 issue #971

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Pins the ubuntu builds to Ubuntu 22.04 LTS due to a .NET 5 OpenSSL dependency issue. We should find a better approach sometime before 22.04 goes out of support in 2027.

Fixes #970

Description

Changes the build agent from ubuntu-latest to ubuntu-22.04.

Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find a better approach sometime before 22.04 goes out of support in 2027.

We will have a better approach soon because we will be able to drop the net6.0 target and use it instead of net5.0 for testing netstandard2.1.

Looks like the azure-pipelines.yml wasn't included, but let's do that because Azure DevOps uses the same images. For that one, we can easily limit this change to net5.0.

@paulirwin paulirwin requested a review from NightOwl888 October 12, 2024 18:58
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed the linux net5.0 tests are producing results on both Azure DevOps and GitHub Actions.

@NightOwl888 NightOwl888 merged commit 24bb0ca into apache:master Oct 13, 2024
199 checks passed
@paulirwin paulirwin deleted the build/ubuntu-22.04 branch October 13, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin Ubuntu build to 22.04 due to .NET 5 build issue
2 participants